[pisa-src] Re: r1088 - in trunk: libpisa pairing pisabeacon pisacd pisand pisasd test tools

  • From: Diego Biurrun <diego@xxxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Mon, 12 Oct 2009 12:51:52 +0200

On Mon, Oct 12, 2009 at 12:46:41PM +0200, Thomas Jansen wrote:
> 
> Log:
> Add to CFLAGS in Makefile.am, do not overwrite them.

Hmmm...

> To build PISA with profiling support, we need an easy way to pass -pg in
> CFLAGS. "CFLAGS=-pg ./configure" builds with profiling support. For more
> detailed instructions please read the documentation in the wiki:
> https://plain.ds-group.info/projects/pisa/cgi-bin/trac.cgi/wiki/DocProfiling

How is this related to your commit?  Seems more like a mailing list
topic.

> --- trunk/libpisa/Makefile.am Mon Oct 12 12:04:18 2009        (r1087)
> +++ trunk/libpisa/Makefile.am Mon Oct 12 12:46:41 2009        (r1088)
> @@ -17,4 +17,4 @@
>  
>  INCLUDES = -I$(PISA_COMMON_INCLUDES) -I$(PISA_LIBPISA_INCLUDES)
> -CFLAGS = -Wall -g
> +CFLAGS += -Wall -g -pg
> 
> --- trunk/pisasd/Makefile.am  Mon Oct 12 12:04:18 2009        (r1087)
> +++ trunk/pisasd/Makefile.am  Mon Oct 12 12:46:41 2009        (r1088)
> @@ -5,7 +5,7 @@
>  
> -CFLAGS = -Wall -g
> +CFLAGS += -Wall -g -pg
>  INCLUDES = -I$(PISA_COMMON_INCLUDES)
>  
> @@ -18,7 +18,7 @@
>  
>  LDADD =
> -LDFLAGS = @LDFLAGS@
> +LDFLAGS = @LDFLAGS@ -pg

Here you add -pg to CFLAGS and LDFLAGS, was this done on purpose?  It
does not match your commit message and should be in a separate commit.

Diego

Other related posts: