[pisa-src] Re: r1032 - in trunk: . pisabeacon
- From: Tobias Heer <heer@xxxxxxxxxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Wed, 07 Oct 2009 09:12:34 +0200
Am 06.10.2009 um 22:06 schrieb Diego Biurrun:
On Tue, Oct 06, 2009 at 09:18:20PM +0200, Tobias Heer wrote:
Log:
Added a sender/receiver component for testing the beaconing
functionality. Functionality and code maturity are far from perfect.
Hmmm, looks like you did not doublecheck the diff before committing..
True, I take the blame.
--- trunk/Makefile.am Tue Oct 6 20:31:25 2009 (r1031)
+++ trunk/Makefile.am Tue Oct 6 21:18:19 2009 (r1032)
- test/packaging/create-package.sh $@
+deb:
+ ${PACKAGING_SCRIPT} deb
This reverts r1023 and r1024. At least 'make dist' will now be
broken.
I see your point. It seems I have subverted subversion by a stupid
copy command. I'll fix it.
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ trunk/pisabeacon/Makefile.am Tue Oct 6 21:18:19 2009 (r1032)
@@ -0,0 +1,25 @@
+
+INCLUDES = -I$(top_srcdir)/include
That path should not be hardcoded, see r1028:
I used pisasd as templete. It seems I just missed the changes you did.
IÄll fix this.
+INCLUDES = -I$(PISA_COMMON_INCLUDES)
+#bin_PROGRAMS =
+#EXTRA_DIST = pisacd.conf
+#sysconf_DATA = pisacd.conf
+#include_HEADERS =
debug junk?
Nope. Leftovers from the template and lack of automake skill.
+#sysconfdir = /etc/pisa
This is bad, it reintroduces the bug I just tried to fix:
Configuration
file paths must not be hardcoded but set by configure.
You noticed that it's a comment?
Recursive make must be eliminated in PISA. It just leads to bugs
getting copypasted around. I'll get to it.
Diego
I'll take care of the issues and try to do better next time.
--
Dipl.-Inform. Tobias Heer, Ph.D. Student
Distributed Systems Group
RWTH Aachen University, Germany
tel: +49 241 80 207 76
web: http://ds.cs.rwth-aachen.de/members/heer
Other related posts:
