[perc-implementation] Re: Status update

  • From: Boris Grozev <boris@xxxxxxxxx>
  • To: perc-implementation@xxxxxxxxxxxxx
  • Date: Thu, 20 Apr 2017 10:29:46 -0500

Hi Sergio,

Thank you for this work and apologies for the late reply.

On 18/04/2017 08:58, Sergio Garcia Murillo wrote:

Hi all,

I have been able to get my modified version of chrome working with
jitsi. The issue is that frame marking is only partially implemented,
and only I frame checks consider the frame marking extension info, there
are two other checks for the start/end of frame that are still done on
the packet payload, which of course were failing when applied to the
encrypted payload.

Here is the patch with the required changes (which can be committed
directly to jitsi/master):

    
https://github.com/jitsi/libjitsi/commit/43c01748fa04a918783d064c6f44f61f373b4ca2

I have forked the bgrozev/jitsi perc branch and backported all the
jitsi/master changes to it before applying the code changes, you can see
the branch here:

    https://github.com/murillo128/libjitsi/tree/jitsi-master

For my local set up I have used nightly jicofo/videobridge/meet-me code
and just change the modified libjitsi.jar from my branch.

Emil, Stephen how do you feel it is the best way to merge this changes
into any of the jitsi branches and have the perc.jitsi.com updated to
latest code?

Emil asked me to help get this merged.

I don't see any reason not to merge these changes to libjitsi/master. Could you rebase the commit on top of master and open a PR (currently it contains reverts of code that is only in the bgrozev/perc branch)? A minor note: the commit also changes the mode of some .java files to 0755.

As for updating perc.jitsi.net -- I can do this right now, based on whatever branch you need.

Another note: we're planning to add signaling for the framemarkings extension (under a jicofo flag) today, and we can add this to perc.jitsi.net.


Regards,
Boris

Other related posts: