[PATCH] tools: Don't cancel reader thread in oping

  • From: Dimitri Staessens <dimitri.staessens@xxxxxxxx>
  • To: ouroboros@xxxxxxxxxxxxx
  • Date: Sun, 4 Mar 2018 10:39:51 +0100

The reader thread was cancelled as soon as the writer was finished,
which resulted in missed responses and misreported packet loss.

Signed-off-by: Dimitri Staessens <dimitri.staessens@xxxxxxxx>
---
 src/tools/oping/oping_client.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/tools/oping/oping_client.c b/src/tools/oping/oping_client.c
index 07fbde7..dbbbfa1 100644
--- a/src/tools/oping/oping_client.c
+++ b/src/tools/oping/oping_client.c
@@ -218,8 +218,6 @@ static int client_main(void)
         pthread_create(&client.writer_pt, NULL, writer, &fd);
 
         pthread_join(client.writer_pt, NULL);
-
-        pthread_cancel(client.reader_pt);
         pthread_join(client.reader_pt, NULL);
 
         clock_gettime(CLOCK_REALTIME, &toc);
-- 
2.16.2


Other related posts:

  • » [PATCH] tools: Don't cancel reader thread in oping - Dimitri Staessens