[openbeosnetteam] Re: Fix in posix headers

  • From: "Niels Reedijk" <n.reedijk@xxxxxxxxx>
  • To: <openbeosnetteam@xxxxxxxxxxxxx>
  • Date: Mon, 1 Dec 2003 06:11:11 +0100

> Hello all,
> 
> I'm concerned about this patch because it makes an assumption about the
> type of sem_id and
> thread_id that may be true now (and for the near future) but may change.

Agreed.

> Is it possible for us to
> put sem_id and thread_id in some place where they can be included without
> us being forced to
> include all of OS.h ? (presumably OS.h would include the same to get the
> same definitions)  It

Well, we can't include OS.h because additional types are defined there and
we don't want those in (I read). So the question is whether it is allowed to
define alternative types in general (if so, this could probably go in
sys/types.h).

> also affects code readability I think.  On the other hand we could
> postpone fixing this until we
> change sem_id and/or thread_id and things start mysteriously breaking in
> networking. :-)

The point is that it breaks the build right now (codycam). I can alter the
patch in such a way that it mentions a huge FIXME, as it will change anyway
when networking is developed.

Niels



Other related posts: