[odamex-bug-reporter] [Bug 773] New: Verify packet integrity with CRC32

  • From: odamex-bugtracker@xxxxxxxxxx
  • To: odamex-bug-reporter@xxxxxxxxxxxxx
  • Date: Thu, 12 Jan 2012 06:03:19 +0000

http://odamex.net/bugs/show_bug.cgi?id=773

             Bug #: 773
           Summary: Verify packet integrity with CRC32
    Classification: Unclassified
           Product: Odamex
           Version: 0.6-dev
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P1
         Component: Server & Client
        AssignedTo: odamex-bug-reporter@xxxxxxxxxxxxx
        ReportedBy: grandpachuck187@xxxxxxxxx


Created attachment 329
  --> http://odamex.net/bugs/attachment.cgi?id=329
Patch for r2714 that implements packet CRC32 checking

UDP provides a 16-bit checksum for verifying the integrity of a packet.  While
this is relatively sufficient (only 1 in 65536 corrupted packets would be
accepted), the UDP checksum is optional, which poses a greater problem.  If a
client's TCP/IP stack does not use the checksum or (more likely) some router
between the client and the server does not use the checksum, corrupted packets
are not being detected.

While I am not sure of the impact this has for Odamex, other non-Doom games
implement their own CRC32 check for each packet sent and received, dropping
corrupted packets.  I have implemented this for Odamex and plan to test it in
the near future with a few players I've come across who experience higher than
normal network related bugs.  Hopefully this will allow me to gauge whether
adding CRC32 checks to packets would be worth the extra 4-byte overhead per
packet.

-- 
Configure bugmail: http://odamex.net/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Other related posts:

  • » [odamex-bug-reporter] [Bug 773] New: Verify packet integrity with CRC32 - odamex-bugtracker