[nvda-addons] Re: commit/placeMarkers: 2 new changesets
- From: Noelia <nrm1977@xxxxxxxxx>
- To: nvda-addons@xxxxxxxxxxxxx
- Date: Tue, 24 Jun 2014 06:38:21 +0200
Hi all, specially reviewers:
Please, I'd like you to review placeMarkers 4.0-dev. I have detected an
issue reading an ebook with ePUBReader, a Firefox add-on, when
navigating between the main text and its notes using hiperlinks. I think
it's fixed now. I have removed the fragment identifier added to acc
value and so to the bookmark filename, which didn't allow to use the
saved place markers.
Please, take care about my bad English in documentation.
Thanks.
El 24/06/2014 6:19, commits-noreply@xxxxxxxxxxxxx escribió:
2 new commits in placeMarkers:
https://bitbucket.org/nvdaaddonteam/placemarkers/commits/e70b71f33404/
Changeset: e70b71f33404
Branch: None
User: norrumar
Date: 2014-06-24 06:13:44
Summary: Removed fragment identifiers in bookmark filenames.
Affected #: 1 file
diff --git a/addon/globalPlugins/placeMarkers.py
b/addon/globalPlugins/placeMarkers.py
index 184e6ed..1ad7f9a 100755
--- a/addon/globalPlugins/placeMarkers.py
+++ b/addon/globalPlugins/placeMarkers.py
@@ -1,4 +1,6 @@
# -*- coding: UTF-8 -*-
+# Removed fragment identifiers in bookmark filenames
+# Date: 24/06/2014
# Support for enhanced skim reading in version 2014.1.
# Date: 13/03/2014
# Support for skim reading.
@@ -286,7 +288,7 @@ class GlobalPlugin(globalPluginHandler.GlobalPlugin):
childID = obj.IAccessibleChildID
IAObj = obj.IAccessibleObject
accValue = IAObj.accValue(childID)
- nameToAdd = " - %s" %
accValue.split("/")[-1].split("\\")[-1]
+ nameToAdd = " - %s" %
accValue.split("/")[-1].split("\\")[-1].split("#")[0]
except:
nameToAdd = ""
file = file.rsplit(" - ", 1)[0]
https://bitbucket.org/nvdaaddonteam/placemarkers/commits/754830192139/
Changeset: 754830192139
Branch: master
User: norrumar
Date: 2014-06-24 06:18:29
Summary: Updated readme.
Affected #: 1 file
diff --git a/readme.md b/readme.md
index 13371a2..011a3b3 100644
--- a/readme.md
+++ b/readme.md
@@ -32,6 +32,9 @@ Using Place markers submenu, under Preferences menu, you can
access:
Note: The bookmark position is based on the number of characters; and
therefore in pages with a dynamic content is better to use the specific search,
and not the bookmarks which save a precise position.
+## Changes for 4.0 ##
+* Removed fragment identifiers from bookmark filenames, which can avoid issues
in ePUBREADER Firefox add-on.
+
## Changes for 3.1 ##
* Translation updates and new language.
* Bookmark position is not announced in skim reading.
Repository URL: https://bitbucket.org/nvdaaddonteam/placemarkers/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.
----------------------------------------------------------------
NVDA add-ons Central: A list for discussing NVDA add-ons
To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.
To unsubscribe, send an email with the subject line of "unsubscribe" (without
quotes) to nvda-addons-request@xxxxxxxxxxxxx.
If you have questions for list moderators, please send a message to
nvda-addons-moderators@xxxxxxxxxxxxx.
Community addons can be found here: http://addons.nvda-project.org
Other related posts:
