Some notes if you want them.
+ if keycode == wx.WXK_RETURN: self.onOk(evt)
+ evt.Skip(True)
Small usability thing:
Does this kill single key nav on the list?
+ errorDialog = wx.MessageDialog(self, _("There is not
any emoticon selected."), _("Error"), wx.OK)
You might use gui.messageDialog if focus isn't set properly.
And yep, your readme looks good. Great job!
On 1/2/2017 8:30 PM, Noelia wrote:
Hi, sorry, I deleted this branch.
Please, review diff from master against 4.7 tag.
Thanks.
El 03/01/2017 a las 2:48, derek riemer escribió:
Hi Noelia:----------------------------------------------------------------
I don't see a 5.0 branch to review. Are you sure it's been pushed?
On 12/21/2016 2:51 PM, Noelia wrote:
Hi, I'm pleased to announce the availability of a 5.0 branch for the
Emoticons add-on, whose main author is Chris Leo, also contributed by
Mesar Hameed, a new author named Francisco Javier Estrada Martínez and
myself.
This new branch contains features that could be available for the next
major version (5.0). These are the changes mentioned in the add-on guide:
Changes for 5.0
• Added support for emojis.
• Improvements for Insert Emoticon dialog with a filter field and
radio buttons to choose displayed emoticons.
• Using guiHelper for Activation settings dialog and Insert Emoticon
dialog: requires NVDA 2016.4 or higher versions
I'd like to request:
- Basic review for the add-on.
- Indept review for the guide, taking care on possible grammar errors
or language improvements.
- Any feed-back that you want to provide.
If pass, we will post the 5.0-dev version on the community add-ons
website, and about two week later, the version could become stable.
Please, note that the new 5.0 branch is located at
https://github.com/nvdaes/emoticons
You can clone this repo or add this remote, and review diffs against
master:
git checkout 5.0
git diff master
Thanks to users, reviewers and the other authors of this great add-on.
Cheers.
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for
reporting bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe:
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
--
------------------------------------------------------------------------
Derek Riemer
* Department of computer science, third year undergraduate student.
* Proud user of the NVDA screen reader.
* Open source enthusiast.
* Member of Bridge Cu
* Avid skiier.
Websites:
Honors portfolio <http://derekriemer.com>
Awesome little hand built weather app!
<http://django.derekriemer.com/weather/>
email me at derek.riemer@xxxxxxxxxxxx <mailto:derek.riemer@xxxxxxxxxxxx>
Phone: (303) 906-2194
NVDA add-ons: A list to discuss add-on code enhancements and for reporting bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe: //www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
