Bhavya shah (il 13/12/2014 14.36) ha scritto:
Hi, I would like to suggest a few things:
Alberto:
hi all, mostly Noelia,
I reviewed the code. Some notes/suggestions:
1) currently, there are two messages when copy has success the first time:
ui.message(_("Adding text to empty clipboard"))
and:
ui.message(_("Appended"))
first is correct, but quite unnecessary, imho.
Same thing clearing clipboard.
About code, for curiosity, why there are onClearAddedText and
script_clear that calls first method, not called anywhere else?
2) according to source code, separator is added also when clipData is
empty string, so we have a separator before the first chunk. An if to
avoid this is simple and reasonable, imho.
3) this is a modify that could be not user-friendly for basic users,
but... use \r, \n or \t as separators? It's not so complicated:
-----
line 57:
bookmark = conf["separator"]["bookmarkSeparator"].decode("string-escape")
line 88:
d = wx.TextEntryDialog(gui.mainFrame, message, title,
defaultValue=bookmark.encode("string-escape"))
line 96:
bookmark = d.GetValue().decode("string-escape")
line 98:
conf["separator"]["bookmarkSeparator"] =
bookmark.encode("string-escape")
-----
So, if you want, you can use \r\n as default separator (\\r\\n indeed),
bookmark instead of self.separator and user will have the control on
blank lines around appended text.
4) maybe in a future release: a checkbox in settings to remove or not
eventually new-line or carriage return chars at the end of copied text
(useful when these chars are included selecting a entire line). An if to
rstrip or not, and voila :)
Sorry for the massive review, but I didn't use this add-on in the past,
and probably I won't use it in the future.
Alberto
----------------------------------------------------------------
NVDA add-ons Central: A list for discussing NVDA add-ons
To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.
To unsubscribe, send an email with the subject line of "unsubscribe"
(without quotes) to nvda-addons-request@xxxxxxxxxxxxx.
If you have questions for list moderators, please send a message to
nvda-addons-moderators@xxxxxxxxxxxxx.
Community addons can be found here: http://addons.nvda-project.org
