[nvda-addons] Re: A small addon for the freeware Ant Renamer
- From: "Joseph Lee" <joseph.lee22590@xxxxxxxxx>
- To: <nvda-addons@xxxxxxxxxxxxx>
- Date: Thu, 4 Dec 2014 13:59:50 -0800
Hi Abdul,
Thanks for the add-on. Some code review for you:
* Overlay class placement: this is just my opinion, but I tend to
favor app modules which includes overlay classes to place them before
defining the app module. That way if a bug is traced to the overlay class,
you don't have to scroll all the way to the bottom to find the offending
line (GoldWave app module is a prime example of this).
* File layout: I do understand that an author may have not
considered layout of the file when creating his or her first add-on. One of
the strengths of Python is readability, and this includes how the file is
laid out. The "unofficial" convention is to separate functions and modules
by a blank line to improve readability and for you to locate the parts of
the file easily.
* In the script method: I think it might be beneficial to somehow
combine the first two if statements (like using a nested conditionals), as
it seems one of them is quite unnecessary.
Thanks. Hope this helps.
Cheers,
Joseph
From: nvda-addons-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] On Behalf Of _abdel_
Sent: Thursday, December 4, 2014 1:29 PM
To: NVDA-addons
Subject: [nvda-addons] A small addon for the freeware Ant Renamer
Hi everyone,
I wanted to present you a small addon for NVDA of my creation, improving the
accessibility of Ant Renamer software with NVDA.
I had already presented you this in a previous post.
Now the addon is a little more comprehensive than its previous version,
Insofar as it now includes a documentation, as well as the opportunity to
see displayed his category among the imput gestures.
You have to find you among the list of actions with CTRL + 2 in order to
view the category Addon among imput gestures, because the principal script
of this addon was created in a overlay class.
The main utility of this extension is to improve The accessibility of the
list of actions that can be accessed with "Ctrl 2".
By default, the focus tends to move to the next control when navigating
among the available actions.
You can download the latest version of this addon from this link :
https://dl.dropboxusercontent.com/u/8085041/Ant-Renamer-addon-1.0.nvda-addon
The compatible version of Ant Renamer is 2.10.
If you want to make any improvements, you can do it.
I am a beginner in terms of scripting to NVDA and the creation of this addon
helped me understand some tricks.
Best regards,
Abdel.
Other related posts:
