I would promote a model similar to the way that the converged Node.js
repository (https://github.com/nodejs/node) is developing, with a dedicated
technical steering community and an approved list of contributors with
commit-level access. Their new organization has a lot of very effective
structure.
On Tue, Aug 18, 2015 at 10:03 PM, Юрий Соколов <funny.falcon@xxxxxxxxx>
wrote:
Concerning Github pool requests and code review: it is not neccessary to
close request and open new after review, - author can just do "push
--force" of a same branch, then Github will update commits in pull request.
This is very convenient for contributor.
19 авг. 2015 г. 4:05 пользователь "Konstantin Osipov" <
kostja@xxxxxxxxxxxxx> написал:
* Mike Pall <mikelj-1508@xxxxxxx> [15/08/19 01:32]:
I'm still merging anything by hand to my repo, which will get
mirrored to GitHub eventually. So don't go overboard on the pull
requests, for now. The git master will change only after the final
2.1 release by me.
Observing some confusion with pull requests already, we found
github pull request system to be unsuitable for our workflow.
In Tarantool, every patch gets approved either by core members of
the team, and often rewritten before accepted into the master
branch. Thus we don't use pull requests, since in this case after
a code review you have to reject the request, do the fixes, and
make a request again.
Instead we've made it very easy to become a project contributor,
but the contributor's guidelines is that work is done on a branch,
and the branch gets merged into the master only after it's
approved.
I guess with LuaJIT the approach could be the same.
Actually, most of the issues won't land in the 2.1 release, since
I want to get that out of the door quickly. I hope to find time to
cut the beta release later this week.
Yes, and it would be nice to create tentative milestones and
attribute issues to the milestones, github allows that.
--
http://tarantool.org - a NoSQL database in a Lua script
