[linux-unicore] 答复: [linux-unicore] Re: [Patch binutils/bfd] Add unicore32 arch and mach for enum bfd_architecture.

  • From: "Guan Xuetao" <gxt@xxxxxxxxxxxxxxx>
  • To: <linux-unicore@xxxxxxxxxxxxx>
  • Date: Mon, 17 Dec 2012 18:05:37 +0800


> -----邮件原件-----
> 发件人: linux-unicore-bounce@xxxxxxxxxxxxx
> [mailto:linux-unicore-bounce@xxxxxxxxxxxxx] 代表 陳韋任 (Wei-Ren Chen)
> 发送时间: Friday, December 14, 2012 10:10
> 收件人: linux-unicore@xxxxxxxxxxxxx
> 主题: [linux-unicore] Re: [Patch binutils/bfd] Add unicore32 arch and mach for
> enum bfd_architecture.
> 
> On Thu, Dec 13, 2012 at 07:49:41PM +0800, 刘智猷 wrote:
> > Hi all,
> >
> > 我开始着手移植bfd。 我在github上建立了一个repo,
> https://github.com/EasyHard/binutils,
> > 下面是我的第一个patch。我不太确定这么发patch对不对,如果不合适,
> 请告诉我~
> >
> > 刘智猷
> 
>   底下內容我覺得沒問題,但我對 binutils 沒有經驗。我想還是由雪濤
> 下定論。一般用 git 發 patch,標題和內容大概會長得像底下這樣:
> 
>   http://lists.gnu.org/archive/html/qemu-devel/2012-12/msg01916.html
> 
> 你的內文漏掉了 "Signed-off-by: "。你看看我的 wiki,看漏掉了什麼設定
> 
>   http://people.cs.nctu.edu.tw/~chenwj/dokuwiki/doku.php?id=git

That's so great!

> 
> 標題的話,因為 linux-unicore 包含許多 linux, qemu 等等。我比較
> 希望看到這樣的標題:
> 
>   [linux-unicore] [binutils] [PATCH]
>                   ^^^^^^^^^^ ^^^^^^^
Btw, use v2 v3 to show your patch version

> 
> 這樣能夠知道這是 binutils 相關,而且是 patch。你可以參考看看。
> 
> > commit 61ff1e39aa043fe146a9ea18c59e57b7832b8307
> > Author: EasyHard <liuzhiyou.cs@xxxxxxxxx>
> > Date:   Thu Dec 13 15:15:47 2012 +0800
> >
> >     Add unicore32 arch and mach for enum bfd_architecture.
> >
> > diff --git a/bfd/archures.c b/bfd/archures.c index c4cefbc..36b1ff4
> > 100644
> > --- a/bfd/archures.c
> > +++ b/bfd/archures.c
> > @@ -464,6 +464,8 @@ DESCRIPTION
> >  .#define bfd_mach_tilegx32  2
> >  .  bfd_arch_aarch64,   {* AArch64  *}
> >  .#define bfd_mach_aarch64 0
> > +.  bfd_arch_unicore32, {* Unicore32 *} .#define bfd_mach_unicore32
> >  .  bfd_arch_last
> >  .  };
> >  */
> 
> --
> Wei-Ren Chen (陳韋任)
> Computer Systems Lab, Institute of Information Science, Academia Sinica,
> Taiwan (R.O.C.)
> Tel:886-2-2788-3799 #1667
> Homepage: http://people.cs.nctu.edu.tw/~chenwj

Other related posts:

  • » [linux-unicore] 答复: [linux-unicore] Re: [Patch binutils/bfd] Add unicore32 arch and mach for enum bfd_architecture. - Guan Xuetao