[linux-unicore] Re: [PATCH] Add definition of bfd_unicore32_arch

  • From: 刘智猷 <liuzhiyou.cs@xxxxxxxxx>
  • To: 陳韋任 (Wei-Ren Chen) <chenwj@xxxxxxxxxxxxxxxxx>
  • Date: Fri, 28 Dec 2012 10:43:37 +0800

Hi,

我也发现了>_< 我发了v2的Patch. 实在不好意思.

刘智猷

2012/12/28 陳韋任 (Wei-Ren Chen) <chenwj@xxxxxxxxxxxxxxxxx>:
> On Fri, Dec 28, 2012 at 10:31:18AM +0800, LIU Zhiyou wrote:
>>
>> Signed-off-by: LIU Zhiyou <liuzhiyou.cs@xxxxxxxxx>
>> ---
>>  bfd/cpu-unicore32.c | 42 ++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 42 insertions(+)
>>  create mode 100644 bfd/cpu-unicore32.c
>>
>> diff --git a/bfd/cpu-unicore32.c b/bfd/cpu-unicore32.c
>> new file mode 100644
>> index 0000000..b80f052
>> --- /dev/null
>> +++ b/bfd/cpu-unicore32.c
>> @@ -0,0 +1,42 @@
>> +/* BFD support for the UniCore32 processor.
>> +   Copyright 2012 Free Software Foundation, Inc.
>> +   Written by LIU Zhiyou
>> +
>> +   This file is part of BFD, the Binary File Descriptor library.
>> +
>> +   This program is free software; you can redistribute it and/or modify
>> +   it under the terms of the GNU General Public License as published by
>> +   the Free Software Foundation; either version 3 of the License, or
>> +   (at your option) any later version.
>> +
>> +   This program is distributed in the hope that it will be useful,
>> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +   GNU General Public License for more details.
>> +
>> +   You should have received a copy of the GNU General Public License
>> +   along with this program; if not, write to the Free Software Foundation,
>> +   Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.  */
>> +
>> +#include "sysdep.h"
>> +#include "bfd.h"
>> +#include "libbfd.h"
>> +
>> +
>> +const bfd_arch_info_type bfd_unicore32_arch =
>> +  {
>> +    32,               /* 16 bits in a word.  */
>                          ^^^^^^^^^^^^^^^^^^^^^^^^
>   不甚了解。代碼和註解兜不上?
>
>> +    32,               /* 32 bits in an address.  */
>> +    8,                /*  8 bits in a byte.  */
>> +    bfd_arch_unicore32,    /* enum bfd_architecture arch.  */
>> +    bfd_mach_unicore32,
>> +    "unicore32",           /* Arch name.  */
>> +    "unicore32",           /* Printable name.  */
>> +    2,                /* Unsigned int section alignment power.  */   /* 
>> TRUE if this is the default machine for the architecture.
>   ^^^^
>
>   "TRUE if ..." 這句話是否可以 80 column 對齊?
>
>> +   The default arch should be the first entry for an arch so that
>> +   all the entries for that arch can be accessed via next. */
>> +    TRUE,             /* The one and only.  */
>> +    bfd_default_compatible,
>> +    bfd_default_scan ,
>> +    0,
>> +  };
>> --
>> 1.8.0.2
>>
>
> --
> Wei-Ren Chen (陳韋任)
> Computer Systems Lab, Institute of Information Science,
> Academia Sinica, Taiwan (R.O.C.)
> Tel:886-2-2788-3799 #1667
> Homepage: http://people.cs.nctu.edu.tw/~chenwj

Other related posts: