[liblouis-liblouisxml] Re: [liblouis/liblouis] fb65ff: Stop buffer overrun in lou_getProgramPath, and als...

  • From: "Arend Arends" <arendarends@xxxxxxxx>
  • To: <liblouis-liblouisxml@xxxxxxxxxxxxx>
  • Date: Thu, 16 Jun 2016 17:44:27 +0200

Has anybody tried to compile LibLouis in Unicode?

It seems to me that overall the code is not written for Unicode strings in the program itself since at many places strings are defined as "...".
Of course the program handles Unicode strings as input and output correctly.

Our program TactileView is in Unicode format and works in many languages. The LibLouis functions are called via a wrapper. This seems to work for computers running on Windows in non-Latin languages such as for instance Russian.

Arend Arends

-----Oorspronkelijk bericht----- From: Christian Egli
Sent: Thursday, June 16, 2016 3:01 PM
To: liblouis-liblouisxml@xxxxxxxxxxxxx
Subject: [liblouis-liblouisxml] [liblouis/liblouis] fb65ff: Stop buffer overrun in lou_getProgramPath, and als...

 Branch: refs/heads/master
 Home:   https://github.com/liblouis/liblouis
 Commit: fb65ff0d254ef6bbbd600bcc8ae66b376f546b7b
     
https://github.com/liblouis/liblouis/commit/fb65ff0d254ef6bbbd600bcc8ae66b376f546b7b
 Author: Michael Curran <mick@xxxxxxxxxxxx>
 Date:   2016-03-09 (Wed, 09 Mar 2016)

 Changed paths:
   M liblouis/compileTranslationTable.c

 Log Message:
 -----------
Stop buffer overrun in lou_getProgramPath, and also free memory after usage.

As compilation on Windows could define "UNICODE", GetModuleFilename may provide a unicode path, yet, further code expects it to be single-byte chars.
Therefore, explicitly use GetModuleFilenameA.


 Commit: 5d4a603f0e022f8d635aefc0751d20a79b29ef73
     
https://github.com/liblouis/liblouis/commit/5d4a603f0e022f8d635aefc0751d20a79b29ef73
 Author: Christian Egli <christian.egli@xxxxxx>
 Date:   2016-06-16 (Thu, 16 Jun 2016)

 Changed paths:
   M liblouis/compileTranslationTable.c

 Log Message:
 -----------
 Merge pull request #160 from nvaccess/getProgramPathBufferOverrun

Stop buffer overrun in lou_getProgramPath, and also free memory after…


Compare: https://github.com/liblouis/liblouis/compare/7e69d7235981...5d4a603f0e02
For a description of the software, to download it and links to
project pages go to http://liblouis.org

Other related posts: