[liblouis-liblouisxml] Re: [liblouis] r1073 committed - making typeform redefineable

  • From: Mesar Hameed <mesar.hameed@xxxxxxxxx>
  • To: liblouis-liblouisxml@xxxxxxxxxxxxx
  • Date: Wed, 23 Oct 2013 18:16:00 +0200

Hi,

The strlen that is used to control the loop at the moment will not work
correctly for things longer than chars.
This is definitely a future bug if it isn't corrected now.

memcpy(emphasis, enteredEmphasis, sizeof(formtype));
Should do it.

Mesar
On Wed 23/10/13,10:51, John J. Boyer wrote:
> It's the same now, but it won't be when typeform is unsigned short int 
> or unsigned int. The value of the #define formtype in liblouis.h.in 
> determines what typeform is.
> 
> I'm glad someone is looking.
> 
> John
> 
> On Wed, Oct 23, 2013 at 05:31:12PM +0200, Christian Egli wrote:
> > Hi John
> > 
> > Why did you change the following? Isn't this exactly the same?
> > 
> > On 10/23/2013 05:12 PM, liblouis@xxxxxxxxxxxxxx wrote:
> > >-        strcpy (emphasis, enteredEmphasis);
> > >+        for (k = 0; k < strlen (enteredEmphasis); k++)
> > >+          emphasis[k] = enteredEmphasis[k];
> > >+        emphasis[k] = 0;
> > 
> > Thanks
> > Christian
> > 
> > -- 
> > Christian Egli
> > Swiss Library for the Blind, Visually Impaired and Print Disabled
> > Grubenstrasse 12, CH-8045 Zürich, Switzerland
> > 
> > 
> > -----
> > Die neue Online-Bibliothek der SBS: Mit wenigen Klicks zum Buch unter 
> > http://online.sbs.ch
> > For a description of the software, to download it and links to
> > project pages go to http://www.abilitiessoft.com
> 
> -- 
> John J. Boyer; President, Chief Software Developer
> Abilitiessoft, Inc.
> http://www.abilitiessoft.com
> Madison, Wisconsin USA
> Developing software for people with disabilities
> 
> For a description of the software, to download it and links to
> project pages go to http://www.abilitiessoft.com

Attachment: signature.asc
Description: Digital signature

Other related posts: