[liblouis-liblouisxml] Re: Updated Cherokee table
- From: Bert Frees <bertfrees@xxxxxxxxx>
- To: liblouis-liblouisxml@xxxxxxxxxxxxx
- Date: Sun, 17 Aug 2014 11:51:01 +0200
OK some of the include statements are indeed changed. I have a few
comment about them:
- Sometimes you include both en-ueb-chardefs.uti and en-ueb-g1.ctb. As
en-ueb-g1.ctb already includes en-ueb-chardefs.uti that doesn't really
make sense, unless some rules are defined in between the includes,
then it can *possibly* matter.
- In some cases you include three chardefs tables: chardefs.cti,
ukchardefs.cti and en-ueb-chardefs.uti. This can't be the intention,
or is it? All the chardefs tables contain more or less the same
characters but the exact definitions may differ, so they are just
overriding each other for the most part. To me this sounds very
brittle and hard to debug. If only a certain part of another table is
needed it is better to either copy that part into your table, or
refactor both tables to included a common table. In case you are
including multiple tables that partly override each other, as you do
now, it is best to include comments that explain why. See also the
check list that Mesar wrote for table contributors[1].
Anyway, you didn't send me a new version of the Cherokee table
(chr-us-g1.ctb that is, in the header of mao-nz-g1.ctb it also says
"Cherokee Braille Table" but I'm assuming that is a copy/paste error?),
so naturally the test results didn't changed either.
If you think these tests failures have to do with the UEB table, could
you work together with them in finding the solution?
Thanks,
Bert
Links:
[1]: http://liblouis.org/posts/check-list_for_table_contributors
Greg Kearney writes:
> Try these as I said everything other than the specifics for the language
> should be based on the included UEB tables. Here are the tables I checked to
> make sure all the include statements are correct.
>
>
> Commonwealth Braille & Talking Book Cooperative
> Greg Kearney, General Manager
> 605 Robson Street, Suite 850
> Vancouver BC V6B 5J3
> CANADA
> Email: info@xxxxxxxxx
>
> U.S. Address
> 21908 Almaden Av.
> Cupertino, CA 95014
> UNITED STATES
> Email: gkearney@xxxxxxxxx
>
>
>
>> On Aug 16, 2014, at 1:26 PM, Bert Frees <bertfrees@xxxxxxxxx> wrote:
>>
>> Hello Greg,
>>
>> I took your information and make a test from it. I just pushed it to the
>> `tables/cherokee_afrikaans_maori_hawaiian' branch. The test fails, but
>> the problem doesn't seem to be spaces before periods. Wherever " ;8 ;v
>> 1" is the expected output, the table produces "8 ;v1" instead. Could you
>> please have a look and see if you can fix this? You can execute the test
>> by running `make chr-us-g1_harness.txt' in the tests/harness directory.
>>
>> Thanks,
>> Bert
>>
>>
>>
>> Greg Kearney writes:
>>
>>> I have gathered together all the information about this project included
>>> the corrected BRF file. It can be downloaded from teh following URL as it
>>> is likely too big to be sent via email.
>>>
>>> http://www.cbtbc.org/cherokee/files/get_in.zip
>>>
>>>
>>> Commonwealth Braille & Talking Book Cooperative
>>> Greg Kearney, General Manager
>>> 605 Robson Street, Suite 850
>>> Vancouver BC V6B 5J3
>>> CANADA
>>> Email: info@xxxxxxxxx
>>>
>>> U.S. Address
>>> 21908 Almaden Av.
>>> Cupertino, CA 95014
>>> UNITED STATES
>>> Email: gkearney@xxxxxxxxx
>>>
>>>
>>>
>>>> On Jul 28, 2014, at 1:40 AM, Bert Frees <bertfrees@xxxxxxxxx> wrote:
>>>>
>>>> Thanks Greg, I've pushed your new table. Won't you forget to send the
>>>> correct translation of your test document so that we can solve the
>>>> "space before period" issue?
>>>>
>>>> Thanks,
>>>> Bert
>>>>
>>>> Greg Kearney writes:
>>>>
>>>>> Here is an updated Cherokee table fixes a few issues with accents and
>>>>> such.
>>>>>
>>>>>
>>>>> Commonwealth Braille & Talking Book Cooperative
>>>>> Greg Kearney, General Manager
>>>>> 605 Robson Street, Suite 850
>>>>> Vancouver BC V6B 5J3
>>>>> CANADA
>>>>> Email: info@xxxxxxxxx
>>>>>
>>>>> U.S. Address
>>>>> 21908 Almaden Av.
>>>>> Cupertino, CA 95014
>>>>> UNITED STATES
>>>>> Email: gkearney@xxxxxxxxx
>>>>
>>>> For a description of the software, to download it and links to
>>>> project pages go to http://www.abilitiessoft.com
>>>
>>> For a description of the software, to download it and links to
>>> project pages go to http://www.abilitiessoft.com
>>
>> For a description of the software, to download it and links to
>> project pages go to http://www.abilitiessoft.com
For a description of the software, to download it and links to
project pages go to http://www.abilitiessoft.com
Other related posts:
