Jamie, When I originally wrote the code for input and output mapping, I wasn't quite sure how contractions should be handled, but I thought that experience would shed some light on it. This has happened, so I'll be happy if you go ahead with your patch. The same goes for the regression problem. I thought the best way to handle the repeated opcode if the cursor fell in a repeated section was not to execute it, but your previous change looked harmless. Again, experience shows us what is needed, so I'll be happy if you patch this also. Thanks, John On Fri, Jan 16, 2009 at 09:19:16PM +1000, James Teh wrote: > Hi all, > > Currently, there is some inconsistency in liblouis's mapping from input > to output positions for contractions. Take the contraction for 'one' in > English grade 2 braille, which translates to 'o"'. The input to output > position map is: > [0, 1, 1] > With an input cursor position of 0, the output cursor position is 1. > This is inconsistent with the input to output map, which indicates that > position 0 should map to position 0. I believe these should be > consistent. I have a patch which fixes this, which I can commit if > people agree. > > Taking this further, the input to output position map indicates that > input characters 1 and 2 should map to output character 1. For most > contractions, I'm not sure this makes sense. If a user places the cursor > on the 'o' in the input, the braille cursor will land on the dot 5 > ('"'), but if the user lands on the 'n' or 'e', the braille cursor will > land on the 'o'. My idea is to just have all characters in the input map > to the start of the contraction, rather than arbitrarily deciding that > all characters ecxept the first should map to the end of the > contraction. All else aside, this means that when scrolling the cursor > to any point in a contraction, the screen reader will always scroll the > entire contraction into view. Are people happy with this? If so, I can > implement it also. > > I hope this made some sense. Feel free to ask me to clarify. :) > > -- > James Teh > Email/MSN Messenger/Jabber: jamie@xxxxxxxxxxx > Web site: http://www.jantrid.net/ > For a description of the software and to download it go to > http://www.jjb-software.com -- My websites: http://www.godtouches.org http://www.jjb-software.com Location: Madison, WI, USA For a description of the software and to download it go to http://www.jjb-software.com