From what I can tell the reason for the liblouis.h.in file is the
definition of widechar. Why not move the definition of widechar to a
separate header which liblouis.h includes. This would mean that the
windows directory build stuff could use liblouis.h from the main code
and have its own version of the widechar header file. As the definition
of widechar is unlikely to change there then would not be the issue of
keeping it synchronised with the one in the main code, or at least it
will only ever happen very rarely.
Michael Whapples
On 21/06/2016 17:15, Christian Egli wrote:
Hi
On 06/21/2016 04:20 PM, Jake Kyle wrote:
I’ve just tried to build the DLL for Liblouis-3.0.0.alpha2 using the
instructions in README.windows. There was the error:
..\liblouis\lou_translateString.c(3993): error C2065: 'no_translate':
undeclared identifier
I noticed that it is declared in the liblouis.h.in file in the
“liblouis-3.0.0.alpha2\liblouis” sub-directory (line 49):
no_translate = 0x0010,
but it is not declared in the liblouis.h file in the
“liblouis-3.0.0.alpha2\windows\include” sub-directory which I presume is
the one that is used for building the DLL in Windows. Instead the
equivalent line (55) declares:
“passage_break = 0x0010,”
Therefore I changed this line to
“no_translate = 0x0010,”
and it works!
Yes, Davy synchronized windows/liblouis.h with liblouis/liblouis.h after I released alpha2. He actually complained about this situation today on irc. We would like a more automated way to keep those two files in sync.
Is this the right fix?
The right fix is probably in https://github.com/liblouis/liblouis/commit/2ad2fddec26ee0f8da61240ac9671bccaabdfb6d.
I was going to recommend to just pull from master, but Davy is in the midst of some refactoring which he will finish on Thursday, so for now I would go with your fix.
Hope that helps and thanks for testing.
Christian
