[hipl-dev] Re: [Merge] lp:~hipl-core/hipl/libhip into lp:hipl
- From: Christof Mroz <christof.mroz@xxxxxxxxxxxxxx>
- To: mp+93782@xxxxxxxxxxxxxxxxxx
- Date: Thu, 23 Feb 2012 17:03:42 -0000
Review: Approve
Unless there's more to come (as you didn't request another review yet), I'm
fine with the proposal.
Note that the early return in the linked list deletion routine is wrong if an
item could be present multiple times.
In this case, in DEBUG configuration it could still be useful to trigger a
HIP_ASSERT if an item is present multiple times but wasn't expected to (of
course, you must always search the complete list then). This not directly
related to this branch though.
If you commit the current version, remember to add bug tracker items concerning
- the non-recursive mkdir(): either always create the directory or never, but
the current solution is something inbetween,
- the forking unit test: Even though forking is the simplest solution, tests
should ideally not rely on their execution environment. Using mock functions
you could also simulate dropped or corrupted packets for hipnetcat, etc.
--
https://code.launchpad.net/~hipl-core/hipl/libhip/+merge/93782
Your team HIPL core team is subscribed to branch lp:hipl.
Other related posts:
