[hipl-commit] [trunk] Rev 4640: lib: core: remove a redundant check.

  • From: Mircea Gherzan <mircea.gherzan@xxxxxxxxxxxxxx>
  • To: hipl-commit@xxxxxxxxxxxxx
  • Date: Sun, 30 May 2010 23:14:09 +0300

Committer: Mircea Gherzan <mircea.gherzan@xxxxxxxxxxxxxx>
Date: 30/05/2010 at 23:14:09
Revision: 4640
Revision-id: mircea.gherzan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Branch nick: trunk

Log:
  lib: core: remove a redundant check.
  The compiler states: "comparison is always false due to
  limited range of data type".

Modified:
  M  lib/core/transform.c

=== modified file 'lib/core/transform.c'
--- lib/core/transform.c        2010-05-30 20:06:25 +0000
+++ lib/core/transform.c        2010-05-30 20:13:18 +0000
@@ -80,11 +80,6 @@
     length     = hip_get_param_contents_len(ht);
     suggestion = (uint16_t *) &ht->suite_id[0];
 
-    if (length > sizeof(struct hip_esp_transform) - sizeof(struct hip_common)) 
{
-        HIP_ERROR("Too many transforms\n");
-        goto out;
-    }
-
     for (i = 0; i < length; i++) {
         switch (ntohs(*suggestion)) {
         case HIP_ESP_AES_SHA1:

Other related posts:

  • » [hipl-commit] [trunk] Rev 4640: lib: core: remove a redundant check. - Mircea Gherzan