On 12/14/18 5:43 PM, Jani Nikula wrote:
On Fri, 14 Dec 2018, Bruno Santos <brunomanuelsantos@xxxxxxxxxxxxxxxxxx>
wrote:
I think you could add something to the docs about installing through pip.
Reason being the same I gave for mentioning arch's package.
Agreed, though I want the packaging merged first.
+# -*- makefile -*-
Ah, modelines, the most telling leak of developer's personal information :p
Seriously though. not every file has it, so I never know if this is
intentional or not.
Frankly the only reason is that emacs doesn't recognize Makefile.local
as a Makefile otherwise. That's the difference between files that have
it vs. not. ;)
If they bug you, I'll take a patch nuking them.
+dir := .
Unused variable?
Just for completeness I guess, to go with the chosen Makefile style
throughout.
Admittedly the whole file is more of a reminder for me how this stuff
works. Just something to get started with. In the end, I want to
automate tagging, releasing, packaging, uploading, etc.
+ python_requires = '>=3', # 3.4?
In that case, I'd like to revisit the relative imports issue. Was there any
other reason to hold that change back other than support Python 2?
I don't think I made myself clear here, allow me to elaborate. I only
wanted to keep supporting python 2 for a very brief transition period,
so that we have a few commits in the git history where both work, and I
could verify everything works using either version. We've got that now,
so I think we're good to go for python 3 only.
Thanks for the review!
