[openbeos] Re: Patch: Prettifying the default decorator
- From: "DarkWyrm" <darkwyrm@xxxxxxxxxxxxx>
- To: openbeos@xxxxxxxxxxxxx
- Date: Fri, 23 Feb 2007 06:08:56 -0500 EST
> As part of a campaign I've gone on to make Haiku look like BeOS R5 as
> close as possible I've made a couple of changes to the
> DefaultDecorator.cpp - one fixes the highlight colour for the window
> tab
> while the other fixes the drawing for the close and resize buttons.
>
> The fix isn't quite finished; I need to find out where B_DARKEN_*
> _TINT
> and its ilk are defined, as well as the function definition for
> tint_color() - at the moment the tinting algorithm is heading towards
> grey, whereas I want it to head towards yellow. Nonetheless I think
> you'll all agree it's a distinct improvement on the original.
> (fFrameColor[3]? What were you THINKING? :P)
That would assume that I was thinking. ;-)
> Screenshots and help compiling etc. courtesy of Urias McCullough. :)
> Before: http://img80.imageshack.us/img80/8827/beforeketsubanbv9.png
> After: http://img80.imageshack.us/img80/8423/afterketsubansx4.png
>
> Attached is a diff file; I'd appreciate it if someone with SVN write
> access could put it into the trunk, if it's not too much trouble.
>
> This is, of course, my first contribution, so be gentle. :)
It's nice work. Really. :-) Just so you know, while it probably needs a
few tweaks to look more professional, the default look for Haiku isn't
going to be just like R5. A major part of what makes people say that R5
looks dated is the window decorator. However, I actually wrote a
decorator specifically for looking like R5, so your patch would
certainly be welcome for that.
You can find the definitions for tint_color and its ilk in src/kits/
interface/InterfaceDefs.cpp.
Now I have an excuse to update those decorators. Thanks!
--DarkWyrm
Other related posts:
