[openbeos] Re: Networks Preferences
- From: "Casalinuovo Dario" <barrett666@xxxxxxxxx>
- To: openbeos@xxxxxxxxxxxxx
- Date: Mon, 14 Apr 2008 15:31:32 +0000
hi, i have fixed style and other issues reported by Stephan, i think
that the code is clean.
this is the patch:
http://bluehq.altervista.org/networkpref.patch
about the question of settings system, i am confused, because i don't
understand if i started off on the right foot :
is my work a good start?
bye
-Dario
2008/4/11, Stephan Assmus <superstippi@xxxxxx>:
> Hi Dario,
>
> Casalinuovo Dario wrote:
> > hi, this is the patch of my work
> > http://bluehq.altervista.org/networkpreferences.patch and this is the
> > screenshot:
> > http://bluehq.altervista.org/myworkshot.png
> > i would like to develop the locations
> > i expect your advice
>
> Your patch shows some nice work, but I have some comments:
>
> * In the NetworkWindow constructor, instead of assigning the view your
> create to the private NetworkWindow member, you assign it to a local
> variable on the stack, whose name shadows the private member.
>
> + NetworkView* fNetworkView = new NetworkView(Bounds());
> + GetLayout()->AddView(fNetworkView);
> ->
> + fNetworkView = new NetworkView(Bounds());
> + GetLayout()->AddView(fNetworkView);
>
> It looks weird that you pass it the Bounds(), with the new layout system,
> it should never need frames anymore.
>
> * You keep switching coding style constantly. Please just follow our coding
> style with regards to spaces, naming, comment style and so on.
>
> * Also on the subject of coding style, we include headers sorted
> alphabetically, except for the header of the class, which is included first
> in order to find any issues with self-containedness of that header.
>
>
> As for advice... doing the gui like that was the easy part with the new
> layout system. :-) The requirements of the network preflet that Waldemar
> describes in the Wiki, mean that you have to come up with a hierarchical
> representation of the settings. It should not be "in" the GUI, but the GUI
> should just be a view onto that data. This means you design classes which
> form the representation of the network configuration and support the
> features that Waldemar describes, for example to inherit options from a
> parent configuration, or shadow identical options locally in a descendant
> configuration. The GUI then just adapts to these settings, or modifies them.
>
> As for the problem with the Network preflet being a GSoC project
> proposal... we had received multiple proposals for the Network preflet
> anyways, so that we gave the advice to these students to place additional
> proposals for projects that also interest them. Most students followed this
> advice, so that we could theoretically distribute and assign all projects
> in a way that no work is duplicated. So this would not be a problem, but
> the real problem is now how many slots we will be assigned by Google.
>
> Best regards,
> -Stephan
>
>
Other related posts:
