[openbeos] Bash readline issue

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: "Open BeOS" <openbeos@xxxxxxxxxxxxx>
  • Date: Wed, 26 Jan 2005 02:06:41 +0100 CET

Hi there,

after some investigation, I couldn't find any reason why we didn't 
append a slash in symlinked directories on tab name completion in the 
shell. And yes, I could reproduce that behaviour when I used our bash 
under BeOS as well.

As it turns out, readline has changed its tab completion behaviour 
since some version. I'd like to ask if you're okay when I apply this 
patch to the repository:

----------------------------------------
RCS file: /cvsroot/open-beos/current/src/apps/bin/bash/lib/readline/
complete.c,v
retrieving revision 1.1
diff -u -r1.1 complete.c
--- complete.c  7 Jun 2004 09:07:26 -0000       1.1
+++ complete.c  26 Jan 2005 01:05:03 -0000
@@ -137,7 +137,7 @@
    readline-4.2a is disabled, and symlinks that point to directories 
have
    a slash appended (subject to the value of 
_rl_complete_mark_directories).
    This is user-settable via the mark-symlinked-directories variable. 
*/
-int _rl_complete_mark_symlink_dirs = 0;
+int _rl_complete_mark_symlink_dirs = 1;
----------------------------------------

I am not entirely sure if this is the right place for the patch, but it 
sure works. And I don't see any reason to adopt that new default 
behaviour of readline for our shell since it's only confusing.

Bye,
   Axel.


Other related posts:

  • » [openbeos] Bash readline issue