[haiku-webkit-commits] Re: r530 - webkit/trunk/WebKit/haiku/WebPositive/autocompletion

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Fri, 16 Jul 2010 13:12:53 +0200

On 2010-07-16 at 10:58:51 [+0200], Stephan Assmus <superstippi@xxxxxx> wrote:
> 
> On 2010-07-16 at 03:13:07 [+0200], webkit@xxxxxxxxxxxxxxx wrote:
> > Author: anevilyak
> > Date: Fri Jul 16 01:13:07 2010
> > New Revision: 530
> > URL: http://mmlr.dyndns.org/changeset/530
> > 
> > Log:
> > Fix crash that occurred when hitting pgup/pgdn in the URL input without
> > having the choice list visible.
> > 
> > Modified:
> >    webkit/trunk/WebKit/haiku/WebPositive/autocompletion/AutoCompleterDefau
> >    lt
> >    Impl.cpp
> > 
> > Modified:
> > webkit/trunk/WebKit/haiku/WebPositive/autocompletion/AutoCompleterDefaultI
> > mp
> > l.cpp
> > ==========================================================================
> > ==
> > ==
> > ---
> > webkit/trunk/WebKit/haiku/WebPositive/autocompletion/AutoCompleterDefaultI
> > mp
> > l.cpp    Fri Jul  9 05:43:32 2010    (r529)
> > +++
> > webkit/trunk/WebKit/haiku/WebPositive/autocompletion/AutoCompleterDefaultI
> > mp
> > l.cpp    Fri Jul 16 01:13:07 2010    (r530)
> > @@ -419,7 +419,14 @@
> >  int32
> >  BDefaultChoiceView::CountVisibleChoices() const
> >  {
> > -    return min_c(fMaxVisibleChoices, fListView->CountItems());
> > +    if (fListView)
> > +    {
> > +        return min_c(fMaxVisibleChoices, fListView->CountItems());
> > +    }
> > +    else
> > +    {
> > +        return 0;
> > +    }
> >  }
> 
> Thanks, but can we please stick to the coding style? ;-)

Sorry for the rushed response... I saw you already fixed it, should have read 
all commit mails before replying. :-)

Best regards,
-Stephan

Other related posts: