[haiku-webkit-commits] r504 - webkit/trunk/WebKit/haiku/WebPositive/tabview

  • From: webkit@xxxxxxxxxxxxxxx
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Wed, 19 May 2010 22:23:51 +0000

Author: stippi
Date: Wed May 19 22:23:51 2010
New Revision: 504
URL: http://mmlr.dyndns.org/changeset/504

Log:
Display tool tips for browser tabs with the page title.

Modified:
   webkit/trunk/WebKit/haiku/WebPositive/tabview/TabContainerView.h
   webkit/trunk/WebKit/haiku/WebPositive/tabview/TabManager.cpp
   webkit/trunk/WebKit/haiku/WebPositive/tabview/TabManager.h

Modified: webkit/trunk/WebKit/haiku/WebPositive/tabview/TabContainerView.h
==============================================================================
--- webkit/trunk/WebKit/haiku/WebPositive/tabview/TabContainerView.h    Wed May 
19 20:07:20 2010        (r503)
+++ webkit/trunk/WebKit/haiku/WebPositive/tabview/TabContainerView.h    Wed May 
19 22:23:51 2010        (r504)
@@ -43,6 +43,7 @@
                virtual void                    DoubleClickOutsideTabs() = 0;
                virtual void                    UpdateTabScrollability(bool 
canScrollLeft,
                                                                        bool 
canScrollRight) = 0;
+               virtual void                    SetToolTip(const BString& text) 
= 0;
        };
 
 public:

Modified: webkit/trunk/WebKit/haiku/WebPositive/tabview/TabManager.cpp
==============================================================================
--- webkit/trunk/WebKit/haiku/WebPositive/tabview/TabManager.cpp        Wed May 
19 20:07:20 2010        (r503)
+++ webkit/trunk/WebKit/haiku/WebPositive/tabview/TabManager.cpp        Wed May 
19 22:23:51 2010        (r504)
@@ -307,6 +307,17 @@
                fTabContainerGroup->EnableScrollButtons(canScrollLeft, 
canScrollRight);
        }
 
+       virtual void SetToolTip(const BString& text)
+       {
+               if (fCurrentToolTip == text)
+                       return;
+               fCurrentToolTip = text;
+               fManager->GetTabContainerView()->HideToolTip();
+               fManager->GetTabContainerView()->SetToolTip(
+                       reinterpret_cast<BToolTip*>(NULL));
+               
fManager->GetTabContainerView()->SetToolTip(fCurrentToolTip.String());
+       }
+
        void CloseTab(int32 index);
 
        void SetCloseButtonsAvailable(bool available)
@@ -333,6 +344,7 @@
        bool                            fCloseButtonsAvailable;
        BMessage*                       fDoubleClickOutsideTabsMessage;
        BMessenger                      fTarget;
+       BString                         fCurrentToolTip;
 };
 
 
@@ -502,6 +514,8 @@
                }
        }
 
+       fController->SetToolTip(Label());
+
        TabView::MouseMoved(where, transit, dragMessage);
 }
 
@@ -696,6 +710,13 @@
 
 
 BView*
+TabManager::GetTabContainerView() const
+{
+       return fTabContainerView;
+}
+
+
+BView*
 TabManager::ContainerView() const
 {
        return fContainerView;

Modified: webkit/trunk/WebKit/haiku/WebPositive/tabview/TabManager.h
==============================================================================
--- webkit/trunk/WebKit/haiku/WebPositive/tabview/TabManager.h  Wed May 19 
20:07:20 2010        (r503)
+++ webkit/trunk/WebKit/haiku/WebPositive/tabview/TabManager.h  Wed May 19 
22:23:51 2010        (r504)
@@ -58,6 +58,7 @@
 #endif
 
                        BView*                          TabGroup() const;
+                       BView*                          GetTabContainerView() 
const;
                        BView*                          ContainerView() const;
 
                        BView*                          ViewForTab(int32 
tabIndex) const;

Other related posts:

  • » [haiku-webkit-commits] r504 - webkit/trunk/WebKit/haiku/WebPositive/tabview - webkit