[haiku-webkit-commits] Re: r312 - webkit/trunk/WebCore/platform/graphics/haiku
- From: Maxime Simon <simon.maxime@xxxxxxxxx>
- To: haiku-webkit-commits@xxxxxxxxxxxxx
- Date: Wed, 17 Mar 2010 13:00:22 +0100
On Wed, Mar 17, 2010 at 12:38, Stephan Assmus <superstippi@xxxxxx> wrote:
> Hi,
>
> On 2010-03-17 at 11:04:41 [+0100], Maxime Simon <simon.maxime@xxxxxxxxx>
> wrote:
> > > And a way to fix this should be to add a & before numGlyphs:
> > >
> > >> view->DrawString(converted.data(), converted.length(), offsets,
> > >> &numGlyphs);
> > >
> > This won't work, a pointer to int isn't a pointer to escapement_delta.
> > It may be an issue from my Haiku installation (I'm in a full gcc4
> > environment.) as no one else seems to have issues with this revision.
>
> It seems you are not following the Haiku commit mailing list. I've had to
> implement a new BView::DrawString() version and backend in the app_server,
> it's also mentioned in the WebPositive commit, but maybe confusingly. Just
> upgrade to the latest Haiku revision and you should be able to compile
> again.
>
> Best regards,
> -Stephan
>
>
Indeed my version of Haiku is r35862 and you added this DrawString()
prototype at r35865. Strangely r35878 was a bit slow (I'm using VMWare
images) so I fallback to r35862.
In fact I don't follow (but I should) the haiku commit mailing list.
And I missed it on this commit mailing list.
Thanks for the tips,
Regards,
--
Maxime
Other related posts:
