[haiku-webkit-commits] Re: Commit Emails

  • From: Ryan Leavengood <leavengood@xxxxxxxxx>
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Mon, 13 Dec 2010 13:12:17 -0500

On Mon, Dec 13, 2010 at 12:43 PM, Stephan Assmus <superstippi@xxxxxx> wrote:
> I thought about this after writing my other mail... one has to consider the
> additional overhead. It will not be as easy to make a change in the WebKit
> layer which affects linking in WebPositive and have everything ready with a
> single "jam" invokation. It would be possible of course to setup a different
> workflow for development, which works independently from the optional build
> dependency. Just saying this may be something to keep in mind.

Yeah it is definitely a consideration.

I think in the long run we will be better off getting our port back up
to speed in the WebKit repo and work against that. I'm sure we can
figure out a decent workflow or some jam magic to make it easier.
Maybe the developers who are actually working on WebKit can put the
WebKit code in their 3rdparty directories and link it in to the Haiku
build, whereas people who just want to hack on WebPositive can just
use the build dependency.

Of course to avoid breakage we would need to make sure the build
dependency is updated every time a commit is made to WebPositive which
relies on changes in the WebKit port.

Because of that I think for a while building WebPositive should be
something that must be opted into (i.e. turned on in the BuildConfig.)
That way most people won't see any breakage if the optional dependency
is not updated fast enough.

Overall I think it is doable and we certainly aren't alone since this
is how all other WebKit clients seem to work.


Other related posts: