[haiku-inc] Re: Gerrit [was: Re: Haiku and GSoC 2016]
- From: Ryan Leavengood <leavengood@xxxxxxxxx>
- To: "haiku-inc@xxxxxxxxxxxxx" <haiku-inc@xxxxxxxxxxxxx>
- Date: Tue, 19 Apr 2016 22:31:57 -0400
On Tue, Apr 19, 2016 at 5:29 PM, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
I wonder who you think will do the reviews. If, in the end, a large portion
of the commits is passed through without actual review -- but considerable
delay -- I'm afraid we don't gain anything.
Good point. It could be reserved only for commits the authors think
are "questionable" and/or could be used only for outside
contributions. It is totally possible to choose to use it or not, I do
so at work. It just depends on where you push.
I am obviously not involved in day-to-day Haiku work anymore, but as
Adrien mentioned in the other thread it has always been a bit
difficult for new people to contribute to Haiku, and Gerrit *might* be
a way to make it a bit easier. Though maybe the barrier to entry is
not found in the act of providing finished code, but rather in setting
up the development environment...which would require other ideas to
improve.
But in the past I recall quite a few patches languishing in Trac for
some time. Though if we add Gerrit maybe they would just languish
there instead. But maybe the plugins and infrastructure around Gerrit
could make some things easier (like verifying that a patch at least
builds.)
--
Regards,
Ryan
Other related posts:
