[haiku-gsoc] Re: localekit patch : plain text catalog (NON WORKING)

  • From: Oliver Tappe <zooey@xxxxxxxxxxxxxxx>
  • To: haiku-gsoc@xxxxxxxxxxxxx
  • Date: Thu, 25 Jun 2009 09:09:02 +0200

Hi,

On 2009-06-24 at 17:10:22 [+0200], PulkoMandy <pulkomandy@xxxxxxxxx> wrote:
> Oliver helped me fix the previous issue, so here is a newer version of
> the patch.

The implementation file for the plaintext-catalog is missing in this patch, 
again. Please take care to only send complete patches, as otherwise it is not 
possible to follow the patch.

> This include some more changes, most notably, i altered the BEINCLUDES
> environment variable to poit to the locale kit directory (it's not
> sufficient to get gcc to pick the headers there, though). I also made
> some changes to CatWalker constructor, as I feel it is simpler to use
> this way.

Well, there was a reason why it was done that way: GetWalker() returns a 
status code that can be used to transport any eventual error condition. 
AFAICS, as the code is now, it is impossible to find out if the CatWalker has 
been initialized correctly at all. 

> Now there is another strange bug I can't fix. My test catalog has just
> one entry in it. When I read it from the plaintext file and call
> Catalog.CountItems(), the returned value is 1. But, when I create a
> CatWalker from it, i get fPos==fEnd, this means the catalog is empty !
> 
> I mus have missed something, but I can't spot the error. Can you help me ?

Maybe the CatWalker isn't initialized correctly - what does GetWalker() 
return?

cheers,
        Oliver

Other related posts: