[haiku-gsoc] Re: locale kit patch : use haiku hash map instead of stl one.
- From: Oliver Tappe <zooey@xxxxxxxxxxxxxxx>
- To: haiku-gsoc@xxxxxxxxxxxxx
- Date: Tue, 21 Jul 2009 21:12:03 +0200
On 2009-07-21 at 18:51:49 [+0200], Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
>
> > + res = archive.AddString("c:ostr", entry.key.fString.String())
> > + || archive.AddString("c:ctxt", entry.key.fContext.String())
> > + || archive.AddString("c:comt", entry.key.fComment.String())
> > + || archive.AddInt32("c:hash", entry.key.fHashVal)
> > + || archive.AddString("c:tstr", entry.value.String());
> > if (res == B_OK)
> > res = archive.Flatten(dataIO);
> > }
> >
> >
> > This code works fine,
>
> It does, but logically or'ing error codes and comparing the result with B_OK
> definitely isn't good practice.
Ah, ok, fixed now - but IIRC that was my code, not Adrien's, so I take the
blame ;-)
cheers,
Oliver
Other related posts:
