[haiku-gsoc] Re: [HCD]: Bfs bug #1

  • From: "Salvatore Benedetto" <emitrax@xxxxxxxxx>
  • To: haiku-gsoc@xxxxxxxxxxxxx
  • Date: Thu, 19 Jun 2008 22:29:10 +0000

2008/6/19 Ingo Weinhold <ingo_weinhold@xxxxxx>:
>
> That looks indeed like a reference is leaked, but that has nothing to do
> with the problem at hand. A vnode is not marked busy after one has a
> reference. And apparently no one has a reference according to your
> screenshots.

Probably not the pager, but the low memory thread does have it.
Anyway, patch attached for the leak. If it looks ok, I'd like to commit it.

>
>> I'm taking a look at the low memory thread handler now.
>>
>> Any comments?
>>
>> BTW: I changed the summary of the ticket as this is not a bfs problem,
>> but rather a vfs one,
>
> I think, if at all, it's more likely a problem of the ide module or related
> modules. It normally shouldn't take more than 10 seconds to write back
> changes to a file. Well unless the file is quite big and there are a lot of
> cache changes... or the system doesn't have an I/O scheduler and starts
> thrashing the disk in low-memory situations. So maybe nothing really goes
> wrong after all; at least nothing that wouldn't be fixed by using a
> condition variable and wait indefinitely. You could try increasing the
> timeout in get_vnode() (maybe to a minute?) and see if the problem still
> occurs.

I'll try that. Anyway I said it's a vfs bug because the code should be
more stable,
and the system should no crash even if the disk is taking ages to write.

>
>> so if mentors think I should go "back" to my HCD just let me know please.
>
> I suppose no one will mind, if you investigate this one or two more days.
> Particularly, since you seem to be able to reproduce it that well. The only
> thing left to find out is whether this is an IDE problem (in which case I
> would recommend handing it over to Marcus) or whether things are just a bit
> too slow for the timeout we allow.

I'm running it in vmware for what it matters at 1Ghz.

Regards,
-- 
Salvatore Benedetto (a.k.a. emitrax)
Student of Computer Engineer
University of Pisa
www.haiku-os.it

Other related posts: