[haiku-development] Re: [patch] Show partition types in DriveSetup
- From: José Manuel <jmfo1982@xxxxxxxxx>
- To: haiku-development <haiku-development@xxxxxxxxxxxxx>
- Date: Mon, 16 Apr 2012 21:09:36 +0200
On Mon, 16 Apr 2012 13:48:19 -0400, John Scipione wrote:
> That being said I find this line to be particularly... interesting.
>
> BString partitionType = (BString) "(" << partition->Type() << ")";
>
> I wouldn't think that casting to a BString like that would work, perhaps
> I'm wrong and that is okay but I'd prefer to see something like this:
Well, yeah, that cast works... and I was amazed also that it did :p
I wrote it like that as that was the shorter way to type it I found,
while keeping the code easy to read.
On Mon, 16 Apr 2012 14:00:24 -0400, John Scipione wrote:
> Even better would be:
>
> BString partitionType(partition->Type());
> partitionType.Prepend("(");
> partitionType.Append(")");
Okay, I've changed the code in this way. I like it, it's more clear to
read. Thanks, John.
I just sent the patch to the ticket in the bug tracker, as you and
Adrien suggested, reopening it:
https://dev.haiku-os.org/ticket/4235
Best regards,
José Manuel
Other related posts:
