On Tue, Aug 7, 2018 at 3:01 AM Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
wrote:
7 août 2018 11:26 "Owen Pan" <owenpiano@xxxxxxxxx> a écrit:
there giving Code-Change: +1- Can this be integrated into Gerrit? It would be great to have a bot
for those of us reviewing theor -1 on submitted patches automatically. It would save a lot of time
changes.
I think it's possible if Gerrit has API's that can be integrated withclang-format API's. However,
I would think that any code submitted to Gerrit should have alreadyreformatted by clang-format or
haiku-format so that this would be unnecessary. :)
Gerrit has two things:
- It can trigger a buildbot (using hooks)
- There is a REST API to submit votes (and do many other things)
It would be convenient to have this done on Gerrit side, so people
submitting patches get
immediate feedback. Ideally, yes, people would always follow the coding
style, but...
I will look into integrating this into vim, too.