[haiku-development] Re: [haiku-commits] haiku: hrev54339 - src/add-ons/input_server/devices/keyboard

From: John Scipione <jscipione@xxxxxxxxx>
To: "haiku-development@xxxxxxxxxxxxx" <haiku-development@xxxxxxxxxxxxx>
Date: Sun, 21 Jun 2020 13:09:18 -0400

On Sat, Jun 20, 2020 at 2:14 PM waddlesplash <waddlesplash@xxxxxxxxx> wrote:

hrev54339 adds 1 changeset to branch 'master'
old head: bbc0611099d7193e484b43d878956433380b9377
new head: f29b4201447f5f93160b7f4b9a3c4ec608499523
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=f29b4201447f+%5Ebbc0611099d7

----------------------------------------------------------------------------

f29b4201447f: Teammonitor: Add 'Open Terminal' button

  * Add a button to open a Terminal to the left of the Cancel button.
    The ALT+OPT+T combo is a bit hidden, as mentioned in #16243.

  * After opening a Terminal, close the Team Monitor. Being a modal
    window, the user would have to close it manually anyway to be able
    to use the Terminal.

  * Remove the unneeded instructions how to use the Quit and Kill buttons.
    Now we can use a simple BStringView and avoid most of the font style
    complications.

  * Put some weight on the scroll view, so it's the only view getting
    taller when vertically resize the window.

  Change-Id: I4a58033c0ce9b36a0e714f9bdd5c5542bca30849
  Reviewed-on: https://review.haiku-os.org/c/haiku/+/2906
  Reviewed-by: waddlesplash <waddlesplash@xxxxxxxxx>

                                        [ Humdinger <humdingerb@xxxxxxxxx> ]

This patch (from the commits list) is fine but in the future it would
be nice if we didn't assume that the Haiku Terminal was the only
option as the terminal application to use as we do here:

void
TeamMonitorWindow::MessageReceived(BMessage* msg)
{
    switch (msg->what) {
        ...
        case kMsgLaunchTerminal:
        be_roster->Launch("application/x-vnd.Haiku-Terminal");
        break;
        ...
}

Instead the code should look up the Terminal to use in the FileTypes
database and then launch that app. By default the FileTypes database
would point to application/x-vnd.Haiku-Terminal but this would allow
the user to change their preferred terminal app.

I'm making a note here for further discussion in case people want to
put their 2 cents in about this.

That is all.

Happy Father's Day everybody.

[haiku-development] Re: [haiku-commits] haiku: hrev54339 - src/add-ons/input_server/devices/keyboard

Other related posts: