[haiku-development] Re: devfs: handle api_version (fwd)
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Thu, 07 Jun 2007 12:35:41 +0200 CEST
"François Revol" <revol@xxxxxxx> wrote:
> This patch should fix handling of unexisting/set-to-1 api_version
> from
> drivers.
> We currently assume it's always there and == 2 and copy the
> [de]select
> hooks regardless.
Good point!
> As version 1 drivers are pre-R4 it's probably not that useful to
> support those, and I could just make it reject api_version not here
> or
> ==1 instead.
> It would avoid adding all that, so I didn't commit it yet, thoughts ?
I think supporting them is pretty simple, so I wouldn't mind adding
this.
However, we do have a style guide, so I have at least two remarks:
- line 134ff, 193ff, & 817ff api_version => apiVersion
- line 193ff default_api_version => defaultApiVersion
Bye,
Axel.
Other related posts:
