On 2014-07-24 at 11:54:39 [+0200], Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote: > > On July 24, 2014 at 1:21 AM Rene Gollent <anevilyak@xxxxxxxxx> wrote: > > On Jul 23, 2014 6:19 PM, "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx> wrote: > > > I'd like to propose commit access for Augustin Cavalier. This is what > > > he's done so far: > > > http://cgit.haiku-os.org/haiku/log/?qt=author&q=waddlesplash > > I'm afraid I'm going to have to vote -1 at this point. While he may be > > enthusiastic, the patches are mostly trivial enough that they don't really > > convince me on a technical front, and what I've seen of his interactions > > on > > the mailing list and elsewhere leave me in serious doubt with regards to > > him being a good fit for the team in general. > > Thanks for being so honest about it! > > Since I don't have such doubts so far, could you elaborate a bit where you > see > the problems with him fitting into the team? I certainly can't speak for Rene, but I'd like to share my view (criticizing behaviour of other people in public is a delicate matter, so I'll try to make this as factual as I can): Having had my share of interactions with Augustin (mostly on IRC), I'm not quite convinced that he's ready for commit access yet. My hesitation is not so much based on an assesment of his technical abilities, as the patches given so far simply haven't been substantial enough for proper evaluation. What I feel I can assess, however, is the communication style/skills and teamworking attitude that Augustin has shown. So far, I have experienced him to be pretty opinionated/bold, for instance on several occasions insisting that there's a bug in Haikuporter when in fact he just didn't understand enough of the context to be able to decide if there really is a bug or not. Additionally, while Augustin obviously is very determined to work on the next Haiku release, I'm not sure I feel very comfortable with the way how he has been going on about it, which involves repeatedly asking other people to do things that he feels should be done now. This kind of behaviour is not a good fit in the context of voluntary open source development, especially not for someone who has not yet become a fully established community member. I have seen Augustin expose considerable boldness in discussions with other people on IRC more than once and he has already been given the advice to drink some more humble juice ... apparently without much effect so far. Once he follows that advice though, I'm confident that Augustin will manage to integrate and become a valuable member of our community, but right now I don't think it would be a good idea to give him commit access (and/or make him our release coordinator/manager). cheers, Oliver