[haiku-development] Re: Trac down, bug report here: efi_gpt.cpp has functions with wrong number of parameters

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Thu, 23 Jul 2009 09:11:21 +0200

On 2009-07-23 at 08:49:44 [+0200], André Braga <meianoite@xxxxxxxxx> wrote:
> Trac is down, so I'm not creating a ticket.
> 
> Seems that ddm_modules.h was changed recently with modifications to the 
> signatures of validate_create_child and create_child. As such, the 
> corresponding efi_gpt_validate_create_child and efi_gpt_create_child must 
> be updated accordingly to account for the additional "const char
> *name" parameter.
> 
> Could someone please fix this? I added them locally and fixed up the call 
> to efi_gpt_validate_create_child inside efi_gpt_create_child, but of 
> course the name is not used anywhere and I don't really know what's the 
> code supposed to do with it. What I will do instead is watch what will be 
> done to fix this so I can actually learn from it :)
> 
> BTW, IMHO it's high time efi_gpt got added to the base image. It's kind 
> of weird that Amiga partitioning scheme *is* added to the base image 
> where nobody could be really using it as their system partition type 
> (only foreign), whereas GPT *is* being used by Intel Mac owners (and me, 
> on the non-Mac side) as their native system partitioning type right now. 
> So this hiccup was totally unnoticed until now that I rebuilt my 
> installation after some two weeks without doing it...

If you've already fixed it locally, why don't you simply include a patch? 
Chances are you fixed it correctly. If you did, you save someone some work, 
if not, no one gets hurt. ;-)

Best regards,
-Stephan

Other related posts:

  1. Home
  2. haiku-development
  3. Archive
  4. 07-2009