[haiku-development] Re: Ticket #820 (Network preflet)

  • From: "Stephan Assmus" <superstippi@xxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Wed, 21 Apr 2010 10:48:10 +0200

Hi,

Barrett <barrett666@xxxxxxxxx> wrote:
> I made a (bad) patch for #820
> (http://dev.haiku-os.org/attachment/ticket/820/preflet.patch) and
> after receving some calls about refreshing that on the actual rev i'm
> asking to myself if my work can be recovered in part, in other words
> what i can save from the Trash.
> 
> This is a link to the previous discussion :
> //www.freelists.org/post/haiku-development/Networks-Preferences-2,1
> 
> As usual the discussion died, and anything of concrete was decided at
> the end, so my questions are :
> What we should do for the preflet? Is an add-on API needed (maybe the
> one in tests/kits/net/preflet)?

the whole Network preflet development is a bit unfortunate. Besides your own 
efforts, there was another effort to resurrect yet another preflet from the 
src/test/ area of the tree. At the time, it wasn't clear how all this would 
unfold. Myself and a few others have tried to give feedback on the Network 
preflet development in general, but it appears no one, including the people who 
have worked on the code, is persistent enough with this issue to push it to be 
finally resolved. I absolutely can see how this may be frustrating to you, but 
sometimes you have to stubbornly find your way into the project. When I first 
became involved with Haiku, I thought I can drop the drawing backend code for 
the app_server and people would be all over it to get it integrated into the 
app_server. This wasn't at all what happened and so I had to become much more 
involved and take matters into my own hands, so to speak.

> Looking at the code my personal plan could be this :
> 
> * Remove some parts (Ethernet*, PPPoE* classes for example)
> * Fix to follow the coding guidelines and fix other issues that my
> incapacity made
> * Extract (and improve?) the add-on API from the test preflet and
> adapt it to my code
> * Write an Ethernet add-on

Most important is a preflet which works, at least as good as the current one, 
and is easy to grasp for the user. Improvements can be iterative. I still have 
a Haiku trunk on one of my machines where I have included your preflet into the 
build. But I never got arround to actually giving it a good testing and a good 
look at the code. I hope it's a consolation that things are not only 
frustrating for you, but also for me (and I presume other core developers) when 
we don't find the time to work off all the stuff that piled up on our TODO 
lists.

Just try to keep at it. Eventually, when you have something that works well 
(just announce when it's ready for testing) and the code is decent and follows 
the coding style, I am sure that you can get this into SVN.

Best regards,
-Stephan

Other related posts: