[haiku-development] Re: The 80 columns limit?

  • From: "Alexander von Gluck IV" <kallisti5@xxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Fri, 03 Sep 2021 13:29:48 +0000

September 3, 2021 8:25 AM, "Alexander von Gluck IV" <kallisti5@xxxxxxxxxxx> 
wrote:

September 3, 2021 3:03 AM, "Fredrik Holmqvist" <fredrik.holmqvist@xxxxxxxxx> 
wrote:

Den fre 3 sep. 2021 kl 08:00 skrev Fredrik Holmqvist 
<fredrik.holmqvist@xxxxxxxxx>:

I think enlarging the limit to 100 characters is sensible, but 90 would
also already make a difference.
Sorry for the accidental empty reply. +1 on 100 chars being the sensible 
compromise.
110 or 90 seems biased.

/Fredrik Holmqvist, TQH

I support anything 100 or less.

The 80 does help "guide" people to refactoring code to be a bit more 
shallow.. but in
some instances on complex things refactoring would reduce readability.

I think some of the crazy conditions in the radeon_hd accelerant might 
highlight this:

https://git.haiku-os.org/haiku/tree/src/add-ons/accelerants/radeon_hd/encoder.cpp#n886

Code like that isn't a standard we should strive for, but refactoring that 
would
result in a big reduction in readability since things are already so complex.


Notice on line 929 I had to sneak in a style violation breaking it apart would
be even worse...

args.v3.sExtEncoder.ucConfig
  |=
    EXTERNAL_ENCODER_CONFIG_V3_DPLINKRATE_2_70GHZ;

Other related posts: