[haiku-development] Re: Review & Pull request for Workspaces app

  • From: Rimas Kudelis <rq@xxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Thu, 15 Dec 2011 16:27:06 +0200

Hi,

2011.12.15 15:25, Stephan Aßmus rašė:
line 308: WorkspacesView::WorkspacesView(BRect frame, bool showDragger=true)
It is invalid to pass the default parameter at this point, it should only be declared in the WorkspacesView class definition (the header).
I believe this is my code, which is already in the repository. https://dev.haiku-os.org/ticket/8156 


line 483: deskbar.RemoveItem (kDeskbarItemName);

Coding Style: No space between method name and opening parenthesis.


Also this.

Rimas

Other related posts:

  1. Home
  2. haiku-development
  3. Archive
  4. 12-2011