[haiku-development] Re: [RFC] BStringView HighColor
- From: François Revol <revol@xxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Tue, 14 Jan 2014 00:34:59 +0100
On 13/01/2014 23:30, John Scipione wrote:
> On Mon, Jan 13, 2014 at 4:52 PM, François Revol <revol@xxxxxxx> wrote:
>> I noticed BStringView checks for the parent color and uses ui_color() as
>> a fallback.
>> I propose we also set the HighColor to ui_color(B_PANEL_TEXT_COLOR), but
>> I'm not sure in which cases.
>> I'd say if (color == ui_color(B_PANEL_BACKGROUND_COLOR)) (either it
>> wasn't set, or the parent's is panel bg).
>>
>> Comments?
>
> What exactly is the problem because the default high and low colors
> set in BView and are black and white respectively. You only want to
> use the B_PANEL_TEXT_COLOR and B_PANEL_BACKGROUND_COLOR if you are
> drawing a panel, which you can't say by default.
>
Well, some themes do set B_PANEL_BACKGROUND_COLOR to black...
François.
Other related posts:
