[haiku-development] Re: [RFC] BStringView HighColor
- From: John Scipione <jscipione@xxxxxxxxx>
- To: "haiku-development@xxxxxxxxxxxxx" <haiku-development@xxxxxxxxxxxxx>
- Date: Mon, 13 Jan 2014 17:30:51 -0500
On Mon, Jan 13, 2014 at 4:52 PM, François Revol <revol@xxxxxxx> wrote:
> I noticed BStringView checks for the parent color and uses ui_color() as
> a fallback.
> I propose we also set the HighColor to ui_color(B_PANEL_TEXT_COLOR), but
> I'm not sure in which cases.
> I'd say if (color == ui_color(B_PANEL_BACKGROUND_COLOR)) (either it
> wasn't set, or the parent's is panel bg).
>
> Comments?
What exactly is the problem because the default high and low colors
set in BView and are black and white respectively. You only want to
use the B_PANEL_TEXT_COLOR and B_PANEL_BACKGROUND_COLOR if you are
drawing a panel, which you can't say by default.
Other related posts: