[haiku-development] Re: Possible commit access?
- From: Jérôme Duval <korli@xxxxxxxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Tue, 25 Jan 2011 11:57:05 +0100
2011/1/24 Stephan Aßmus <superstippi@xxxxxx>:
> I've looked at the changesets you linked. It's not so easy judging your
> coding skills from those, but style cleanup and fixes are certainly
> important and appreciated. Then I've looked at your USB wimax driver project
> and skimmed over some files, it definitely looks well written to me. As you
> say, you've been a long time contributer and active community member. So I
> think giving you commit access is well deserved, you would be a valuable
> addition to the team and the work you already do would get easier for you
> and more accessible for others!
Same thoughts here. Though I noticed at least one style violation in
this patchset: https://dev.haiku-os.org/changeset/37757 (committed by
Philippe btw :)) and a lot in
https://github.com/kallisti5/usb_beceemwmx.
Definitely not blocking IMO, provided the code style improves.
Bye,
Jérôme
Other related posts:
