[haiku-development] Possible bug in BFS?

  • From: Janito Ferreira Filho <jvffprog@xxxxxxxxxxx>
  • To: Haiku Development <haiku-development@xxxxxxxxxxxxx>
  • Date: Sat, 14 Aug 2010 18:27:21 +0000

Hi,

I spotted something that looks weird to me, can someone confirm if it really is 
a bug or if I'm missing something?

In the end of bfs_rename, one of the last things it does is remove from the 
entry cache the old file name in the old 
directory (here old = source), and then add the new file name in the new
 directory (new = destination). It then closes the transaction, and if it 
that fails
(status != B_OK), it enters the code I pasted in pastebin. Originally, it 
removes 
from the entry cache the new file name in the old directory, and adds the old 
file name in 
the new directory. If the idea is to restore the entry cache state, 
shouldn't it remove the new file name in the
new directory and add the old file name in the old directory?

Should I open a ticket?

Patch: http://pastebin.com/QQhxFfJn

Thank you,

Janito
                                          

Other related posts: