[haiku-development] Re: Patch reviews - help needed
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Thu, 06 May 2010 14:26:42 +0200
On 2010-05-06 at 12:19:05 [+0200], Alexandre Deckner <alex@xxxxxxxxxxxx>
wrote:
> Stephan Assmus wrote:
> > [...] it would be very nice if more regular
> > contributors would review patches and we would share the load better.
> > After
> > all, the goal here is to give people SVN access eventually and gain new
> > contributors. We should be very happy to receive patches!
>
> In my case, it's because i'm confortable with only a few specific areas
> of the code base.
Same here (though it might be a few more areas and I would use the phrase
"feel responsible for"). I guess the problem with this approach is that we
simply don't cover the full code base with it. Particularly many
applications, preflets, and add-ons, for which quite a few layouting and
localization patches have been made recently, are not really owned by anyone
(though, admittedly, I refuse to even look at localization patches before
#5408 is dealt with).
> > Now, I realize the problem may be that subscribing to the general Trac
> > notification list could be the issue here. It's just too much, I've
> > considered unsubscribing from Trac notifications as well.
>
> I try to keep up too, but never considered unsubscribing. It's too
> important IMO.
With a working triaging as proposed not too long ago it would be way less
important to be subscribed to the list. Though it's still nice to at least
have a rough idea of what issues are reported, and from time to time I also
think I can add a useful comment to ticket that doesn't directly concern me.
On 2010-05-06 at 13:08:50 [+0200], Stephan Assmus <superstippi@xxxxxx> wrote:
> On 2010-05-06 at 12:52:35 [+0200], Ithamar R. Adema
> <ithamar.adema@xxxxxxxxxxxxxxxx> wrote:
> > Stephan Assmus wrote:
> > > Now, I realize the problem may be that subscribing to the general Trac
> > > notification list could be the issue here. It's just too much, I've
> > > considered unsubscribing from Trac notifications as well. Sometimes I
> > > spend
> > > two hours or more each morning just to stay on top of all the Haiku
> > > related
> > > emails, the bulk of them being Trac emails, and those are just the mails
> > > from when I was sleeping. Even worse, I get every notification twice for
> > > tickets that I have commented on, or for tickets that I have been
> > > assigned
> > > to. Maybe for those reasons, most developers have unsubscribed from the
> > > Trac list? Who is still subscribed? It would be a good explanation why
> > > patches go unnoticed. Maybe the best solution would be to forward patch
> > > notifications to a separate list? That way, one could sign up for those,
> > > but not for all Trac notifications in general.
> > >
> > Maybe I've missed older discussions, or maybe I'm just thick, but what
> > is the reason that patches aren't sent to this list? With a [PATCH]
> > marker in the subject any uninterested parties could just ignore them....
>
> Mainly because whenever patches were sent to this list in the past, they
> tended to be forgotten eventually. In Trac, at least they stay available and
> in the right context. Personally I don't see the difference between getting
> additional mails on this list, or the very same mails from a different list.
With the difference that the ticket list is very busy and it's relatively
easy to miss a patch. Particularly for those who aren't even subscribed to
the list. :-)
> That is if the separate patch notifications for Trac can be implemented. It
> would be the best of both.
Probably. A "Commit" button in Trac would also be great. Especially for small
patches the overhead for downloading, applying, and committing the patch
manually is often greater than for reviewing it.
CU, Ingo
Other related posts:
