[haiku-development] Re: Patch format?

  • From: Ingo Weinhold <ingo_weinhold@xxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Wed, 31 Mar 2010 23:12:31 +0200

On 2010-03-31 at 23:06:13 [+0200], pete.goodeve@xxxxxxxxxxxx wrote:
> Looking at the patch man page [which of course I should have done first!]
> it seems to be pretty smart about not doing the wrong thing.  Perhaps
> the best thing to do would be to edit in an "Index:" line to directly
> indicate the file name.

You don't have to edit the patch.

> However, where is the patch usually executed
> from?  Should I include a path from "haiku/...", or just give the filename
> itself, assuming that the patcher goes to the directory first? (The only
> patch I could find quickly by scanning a few tickets did the latter.)
> If the former, should it be "haiku/trunk/src/..." or something else?

Generally patches created from within the checked out trunk directory are 
preferred. Additional directory levels aren't a problem either, as they can 
easily be stripped with patch's '-p' option. Patches from inner directories 
are bothersome, though.

CU, Ingo

Other related posts: