[haiku-development] Re: Patch format?

  • From: pete.goodeve@xxxxxxxxxxxx
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Wed, 31 Mar 2010 14:06:13 -0700

On Wed, Mar 31, 2010 at 10:15:28PM +0200, PulkoMandy wrote:
> Le Wed, 31 Mar 2010 22:13:42 +0200, <pete.goodeve@xxxxxxxxxxxx> a écrit:
> 
> >I can edit the text to match what SVN would produce, except that I'm
> >not even sure of the revision of the source I have.  It is 'alpha 1',
> >but downloaded from berlios, so there is no specific rev number that
> >I can find.
> 
> That'a a problem. Usually the patches are applied with 'patch -p0 < file',  
> so the svn rev doesn't matter. However, basing your patch on an old  
> sourcecode will likely make it unuseable in a more recent version.
> 
In this case at least (midi_server) that shouldn't be a problem, because
I'm fairly certain there have been no changes since the version I have.
Otherwise I'd make sure that I have the latest source first.

Looking at the patch man page [which of course I should have done first!]
it seems to be pretty smart about not doing the wrong thing.  Perhaps
the best thing to do would be to edit in an "Index:" line to directly
indicate the file name.  However, where is the patch usually executed
from?  Should I include a path from "haiku/...", or just give the filename
itself, assuming that the patcher goes to the directory first? (The only
patch I could find quickly by scanning a few tickets did the latter.)
If the former, should it be "haiku/trunk/src/..." or something else?

Thanks,
                -- Pete --


Other related posts: