[haiku-development] Re: Patch format?

  • From: PulkoMandy <pulkomandy@xxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Wed, 31 Mar 2010 22:15:28 +0200

Le Wed, 31 Mar 2010 22:13:42 +0200, <pete.goodeve@xxxxxxxxxxxx> a écrit:

Sorry for this rather ignorant question, but when I submit a patch
to Trac, how critical are the IDs in the diff?  Being SVN-deprived,
I have to do a 'diff -u' on the original and modified files, so
although the diff details are correct, the file paths are not what
SVN would expect.  (I'm not even sure how the updater will use the
diff.)

I can edit the text to match what SVN would produce, except that I'm
not even sure of the revision of the source I have.  It is 'alpha 1',
but downloaded from berlios, so there is no specific rev number that
I can find.

That'a a problem. Usually the patches are applied with 'patch -p0 < file', so the svn rev doesn't matter. However, basing your patch on an old sourcecode will likely make it unuseable in a more recent version.

--
Adrien Destugues / PulkoMandy
http://pulkomandy.ath.cx

Other related posts: