[haiku-development] Re: Patch for #1816

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Thu, 10 Jul 2008 08:55:44 +0200 CEST

Hi,

PulkoMandy <pulkomandy@xxxxxxxxx> wrote:
> here is a patch for bug #1816. The background is now cleared to white
> before text is drawn. However, i had to "bruteforce" white color
> selection as both HighColor and LowColor on the view are set to black
> when drawing... i didn't see any drawing problem, however changing
> some colors in the settings may lead to strange results...
> Attached patch applies to haiku/src/kits/tracker/TextWidget.cpp .

I'm not sure if this is the right way to go - it causes an additional 
background clearing even when it's not necessary. This is especially 
not wanted if we ever have background images in list view mode as well 
(probably not so soon, though).
Other widgets are using the same drawing code, but don't have this 
problem (like when the size, the name, or some attribute changes 
outside of Tracker).

Bye,
   Axel.


Other related posts: